Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements new persona api #6000

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Implements new persona api #6000

merged 4 commits into from
Jul 28, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 3, 2020

Resolves brave/brave-browser#8428

Submitter Checklist:

Test Plan:

plan 1:

  • enable rewards
  • make sure that wallet is created
  • open Preference file and make sure that brave.rewards.wallet has payment_id and seed populated

plan 2:

  • enable rewards
  • try to restore wallet
  • make sure that wallet is restored correctly

plan 3:

  • enable rewards
  • open restore modal
  • put 16 random words in there
  • make sure that you see migration message

plan 4:

  • enable rewards
  • restore wallet with user funds
  • connect kyc uphold account
  • make sure that funds are transferred

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jul 3, 2020
@NejcZdovc NejcZdovc force-pushed the new-persona branch 3 times, most recently from f7f7f6b to e28b725 Compare July 4, 2020 05:19
@NejcZdovc NejcZdovc force-pushed the new-persona branch 7 times, most recently from 7b7e68c to 214399b Compare July 16, 2020 09:23
@NejcZdovc NejcZdovc marked this pull request as ready for review July 16, 2020 09:49
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 16, 2020
@NejcZdovc NejcZdovc force-pushed the new-persona branch 2 times, most recently from 16ebe5d to 02039ef Compare July 16, 2020 13:48
@NejcZdovc NejcZdovc requested review from a team, zenparsing and emerick and removed request for a team July 16, 2020 14:09
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 duped line that needs removal but everything else looks good

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ads code lgtm

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc force-pushed the new-persona branch 3 times, most recently from 5150f70 to 5aa7700 Compare July 22, 2020 06:31
@srirambv
Copy link
Contributor

@NejcZdovc can you please add Android specific test plan. Issue is marked to be checked on Android as well

@NejcZdovc
Copy link
Contributor Author

@srirambv everything should go with Android except plan 1 where you can ignore step 3

tmancey added a commit that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new persona creation
6 participants